マジックナンバーはやめてくれ

<?php
...
if($v[26] != 1 AND in_array($v[1], $s)) $hoges[] = $v;
...
$fuga = array_column($hoges, 3);
...
if($v[3] === $vs) $piyos[] = $v;
...
foreach($piyos as $vc) {
	if($val[6] === $vc[0]) {
		echo trim($vc[1]);
		if($vc[1] !== '' AND $vc[2] !== '') echo '、';
		if($vc[2] !== '') echo trim($vc[2]);
		....
	}
} 

• ◯◯取得処理

せめてkeyは振り直してくれ

public function setKey(array $row): array
{
    $array = [];
    foreach ($row as $index => $value) {
        switch ($index) {
            case 0:
                $array['name'] = $value;
                break;
            case 1:
                $array['email'] = $value;
                break;
            .....
        }
    }
    return $array;
}

ハードコーディングがあちこちにあるんじゃ

📁 root/functions/function.php

<?php
...

function hoge_fuga_201901($f)
{
    $d = [];
    if ($f == '/hoge/fuga') {
        $json = file_get_contents($_SERVER[ 'DOCUMENT_ROOT' ]."/dev/hoge/fuga/piyo/baz.json");
        .....
    } else {
        $csv_path = $_SERVER[ 'DOCUMENT_ROOT' ].$f.".csv";
        .....
    }
    return $d;
}

function hoge_fuga_201901($f)

function get_csv_201901($f)

if ($f == '/hoge/fuga') {

　　　　　　　　if ($f == '/hoge/fuga') {
        $json = file_get_contents($_SERVER[ 'DOCUMENT_ROOT' ]."/dev/hoge/fuga/piyo/baz.json");
        .....
    } else {
        $csv_path = $_SERVER[ 'DOCUMENT_ROOT' ].$f.".csv";
        .....
    }

$json = file_get_contents($_SERVER[ 'DOCUMENT_ROOT' ]."/dev/hoge/fuga/piyo/baz.json");

..."/dev/...

dev

prod

Configファイルを作ってくれ

📁 root/config.php

<?php

const ROOT = __DIR__ . '/..';

// テスト環境->dev,本番環境->prod
const TARGET_DIR = '/dev';

const HOGE_FUGA = '/hoge/fuga';

const BAZ_JSON_PATH = ROOT.TARGET_DIR.'/hoge/fuga/piyo/baz.json';

...

<?php

require_once(__DIR__.'/../config.php');　

function hoge_fuga_201901($path)
{
　　　　　　　if ($path === HOGE_FUGA) {
        $json = file_get_contents(BAZ_JSON_PATH);// root/dev(prod)/hoge/fuga/piyo/baz.json
        .....
    } else {
        $csv_path = ROOT.$path.'.csv';// root/hoge/fuga.csv
        .....
    }
}

終わりに